maint(ci): remove autogenerated invariant docs #11988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartcontracts
requested review from
skeletor-spaceman,
sebastianst,
tynes and
mds1
and removed request for
sebastianst and
skeletor-spaceman
mds1
approved these changes
Sep 18, 2024
|
Pending comments from Wonderland |
smartcontracts
force-pushed
the
sc/ci-no-invariant-docs
branch
from
9834b45
to
81e1d2f
Compare
Removes autogenerated invariant docs from the contracts package. These autogenerated docs create confusion about where invariants should be defined (the answer is in the specs) and no one actually looks at them anyway. Just adds an additional step into CI for minimal benefit.
smartcontracts
force-pushed
the
sc/ci-no-invariant-docs
branch
from
81e1d2f
to
8b9b9f8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #11988 +/- ##
===========================================
- Coverage 79.10% 78.87% -0.24%
===========================================
Files 41 41
Lines 3437 3437
===========================================
- Hits 2719 2711 -8
- Misses 548 557 +9
+ Partials 170 169 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
skeletor-spaceman
approved these changes
Sep 19, 2024
tynes
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes autogenerated invariant docs from the contracts package. These autogenerated docs create confusion about where invariants should be defined (the answer is in the specs) and no one actually looks at them anyway. Just adds an additional step into CI for minimal benefit.
Closes #11251