Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable go patches for cannon MT #11937

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Disable go patches for cannon MT #11937

merged 2 commits into from
Sep 17, 2024

Conversation

ajsutton
Copy link
Contributor

Description

Don't patch out the GC when creating the cannon MT prestate.

Also fixes the devnet file list for devnet to use the binary cannon MT prestates.

Fix the prestate file list for devnet to use the binary cannon MT prestates.
@ajsutton ajsutton requested a review from a team as a code owner September 17, 2024 04:09
@ajsutton ajsutton requested review from tynes and Inphi and removed request for tynes September 17, 2024 04:09
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

semgrep-app bot commented Sep 17, 2024

Semgrep found 1 sol-style-return-arg-fmt finding:

  • packages/contracts-bedrock/src/L1/OPStackManager.sol

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

@Inphi Inphi added this pull request to the merge queue Sep 17, 2024
Merged via the queue into develop with commit 3b4fcc5 Sep 17, 2024
59 of 60 checks passed
@Inphi Inphi deleted the aj/mt-gc branch September 17, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants