Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-challenger: Support MT-Cannon in run-trace #11934

Merged
merged 6 commits into from
Sep 19, 2024
Merged

op-challenger: Support MT-Cannon in run-trace #11934

merged 6 commits into from
Sep 19, 2024

Conversation

Inphi
Copy link
Contributor

@Inphi Inphi commented Sep 17, 2024

Add an option to the op-challenger run-trace subcommand that runs MT-Cannon right after generating a cannon trace.

The MT-Cannon run uses the same inputs as Cannon so we can easily compare the two runs.

op-challenger/game/fault/trace/prestates/multi.go Outdated Show resolved Hide resolved
op-challenger/runner/runner.go Outdated Show resolved Hide resolved
op-challenger/cmd/run_trace.go Show resolved Hide resolved
@Inphi Inphi marked this pull request as ready for review September 18, 2024 07:54
@Inphi Inphi requested review from a team as code owners September 18, 2024 07:54
Copy link
Contributor

@mbaxter mbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - just a few questions

op-challenger/game/fault/trace/prestates/multi.go Outdated Show resolved Hide resolved
op-challenger/game/fault/trace/prestates/multi_test.go Outdated Show resolved Hide resolved
op-challenger/runner/runner.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

op-challenger/cmd/run_trace.go Outdated Show resolved Hide resolved
@ajsutton
Copy link
Contributor

If you rebase it will fix semgrep but I think you can merge anyway.

@Inphi Inphi added this pull request to the merge queue Sep 19, 2024
Merged via the queue into develop with commit 4b8d23e Sep 19, 2024
61 checks passed
@Inphi Inphi deleted the inphi/mt-runner branch September 19, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants