Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannon: Handle unaligned futex addresses #11929

Conversation

mbaxter
Copy link
Contributor

@mbaxter mbaxter commented Sep 16, 2024

Description

Align the futex address argument upfront. Use the aligned address in the State.Wakeup and ThreadState.FutexAddr fields.

Tests

Add tests with unaligned address arguments for FutexWait and FutexWake. Add tests for handling a waiting thread with an unaligned FutexAddr.

Metadata

Fixes #11650

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.43%. Comparing base (4af1fe6) to head (3b4060f).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11929      +/-   ##
===========================================
+ Coverage    79.42%   79.43%   +0.01%     
===========================================
  Files           41       41              
  Lines         3412     3414       +2     
===========================================
+ Hits          2710     2712       +2     
  Misses         532      532              
  Partials       170      170              
Flag Coverage Δ
cannon-go-tests 79.43% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cannon/mipsevm/multithreaded/mips.go 95.69% <100.00%> (+0.02%) ⬆️

@mbaxter mbaxter requested a review from Inphi September 16, 2024 20:15
@mbaxter mbaxter marked this pull request as ready for review September 16, 2024 20:16
@mbaxter mbaxter requested review from a team as code owners September 16, 2024 20:16
packages/contracts-bedrock/src/cannon/MIPS2.sol Outdated Show resolved Hide resolved
@mbaxter mbaxter added this pull request to the merge queue Sep 16, 2024
Merged via the queue into ethereum-optimism:develop with commit 95765df Sep 16, 2024
58 checks passed
@mbaxter mbaxter deleted the issue-11650/handle-unaligned-futex-addrs branch September 16, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle unaligned futex addresses
2 participants