op-e2e: Separate helpers for proofs action tests into a new package #11920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
requested review from
mbaxter,
clabby and
protolambda
and removed request for
mbaxter
|
@protolambda Flagging this mostly as a FYI since you've done a lot of work on the actions tests. Please yell if you think this is the wrong direction. |
protolambda
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separates the actual tests from the helpers by introducing a new
op-e2e/actions/proofs/helperspackage. This makes it much easier to find the actual e2e tests, particular if in the future the helpers have their own unit tests as well.Only applied to the proofs helpers currently but will apply this pattern to other tests in follow up PRs.