Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the deterministic deployer when broadcasting with CREATE2 #11915

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Use the deterministic deployer when broadcasting with CREATE2 #11915

merged 1 commit into from
Sep 15, 2024

Conversation

mslipper
Copy link
Collaborator

No description provided.

@mslipper mslipper requested review from a team as code owners September 14, 2024 08:09
protolambda
protolambda approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe consider adding a host option to enable this behavior explicitly. But makes sense for broadcast of create2 otherwise.

@mslipper
Copy link
Collaborator Author

Added a host flag as per your suggestion.

@mslipper mslipper added this pull request to the merge queue Sep 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 15, 2024
@protolambda protolambda added this pull request to the merge queue Sep 15, 2024
Merged via the queue into develop with commit 92ed64e Sep 15, 2024
60 checks passed
@protolambda protolambda deleted the feat/deterministic-broadcast branch September 15, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda approved these changes

@axelKingsley axelKingsley Awaiting requested review from axelKingsley axelKingsley is a code owner automatically assigned from ethereum-optimism/op-stack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mslipper @protolambda