op-batcher: Add String methods to txRef #11904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A small test showing what the final output looks like could be very useful |
ajsutton
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
StringandTerminalStringmethods to thetxReftype.Additional context
The
txReftype is currently printed in logs likeid="{id:[{chID:[80 163 8 115 105 69 5 101 201 15 231 22 117 64 81 242] frameNumber:0} {chID:[80 163 8 115 105 69 5 101 201 15 231 22 117 64 81 242] frameNumber:1}] isCancel:false isBlob:true}"which is not only ugly, but also doesn't print the channel id in hex, so filtering to a particular channel id by its hex string misses these logs.