refactor: single source of truth for DerivationVersion#11901
Merged
protolambda merged 4 commits intoethereum-optimism:developfrom Dec 6, 2024
Merged
refactor: single source of truth for DerivationVersion#11901protolambda merged 4 commits intoethereum-optimism:developfrom
DerivationVersion#11901protolambda merged 4 commits intoethereum-optimism:developfrom
Conversation
protolambda
approved these changes
Nov 19, 2024
Contributor
|
/ci authorize ec6849f |
protolambda
reviewed
Dec 6, 2024
Contributor
protolambda
left a comment
protolambda
left a comment
There was a problem hiding this comment.
It already auto-merged, but changes after merge of develop all are still correct 👍
sigma
pushed a commit
that referenced
this pull request
Dec 19, 2024
* single source of truth for DerivationVersion * op-node/rollup: fix imports --------- Co-authored-by: protolambda <proto@protolambda.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
DerivationVersion1is not used, andTxDataVersion1is used instead, both refer to the same thing.This PR makes
versions.gothe single source of truth forDerivationVersion.