Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

semgrep: try to fix CI timeout #11798

Merged
merged 1 commit into from
Sep 7, 2024
Merged

semgrep: try to fix CI timeout #11798

merged 1 commit into from
Sep 7, 2024

Conversation

protolambda
Copy link
Contributor

Description

  • Apply timeout via CLI flag. Env var might be misapplied and is inconsistent in semgrep docs. A 100s per rule and file ought to be enough.
  • List time of semver rules, so we can tell what is slow and causing problems
  • Limit memory, to stay under the circle CI resource class memory. It might have been using swap memory.
  • Apply timeout to semgrep as a whole. If it takes longer than 20m without output, something is very wrong, and it should just stop, instead of running for 5 hours.

@protolambda protolambda requested a review from a team as a code owner September 7, 2024 20:14
@tynes tynes added this pull request to the merge queue Sep 7, 2024
Merged via the queue into develop with commit 4fbe14f Sep 7, 2024
62 checks passed
@tynes tynes deleted the semgrep-timeout branch September 7, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tynes tynes tynes approved these changes

@smartcontracts smartcontracts Awaiting requested review from smartcontracts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@protolambda @tynes