Add entrypoint to deploy against existing Superchain #11791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
mslipper
force-pushed
the
feat/existing-superchain-entrypoing
branch
from
c58cd62
to
cb5191d
Compare
mslipper
force-pushed
the
feat/existing-superchain-entrypoing
branch
2 times, most recently
from
41ea87e
to
caa913d
Compare
Creates a separate entrypoint in the deploy script to allow an L2 to be deployed against an existing set of Superchain contracts. The deployment assumes that the Superchain contracts have been deployed correctly. The L2 still gets its own ProxyAdmin, AddressManager, and Safe. The API is additive and backwards-compatible.
mslipper
force-pushed
the
feat/existing-superchain-entrypoing
branch
from
caa913d
to
87c90ae
Compare
maurelian
reviewed
Sep 9, 2024
There was a problem hiding this comment.
TBH I had some trouble following the logic, with all the various run functions, but I'm starting to see how it makes sense and minimizes actual diffs.
I think it's tech debt that the same proxy admin is used for OP Mainnet and the Superchain contracts, but I don't think we should fix that here/now.
If you're good with the suggestion, I'll finalize my reviewing by comparing before and after state dumps.
Co-authored-by: Maurelian <[email protected]>
|
Suggestions accepted - let me know if you need anything else! |
maurelian
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a separate entrypoint in the deploy script to allow an L2 to be deployed against an existing set of Superchain contracts. The deployment assumes that the Superchain contracts have been deployed correctly. The L2 still gets its own ProxyAdmin, AddressManager, and Safe. The API is additive and backwards-compatible.