Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: more blueprint tests #11782

Merged
merged 3 commits into from
Sep 6, 2024
Merged

test: more blueprint tests #11782

merged 3 commits into from
Sep 6, 2024

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Sep 6, 2024

Follow on to #11700, see also #11623

@mds1 mds1 requested a review from blmalone September 6, 2024 14:42
@mds1 mds1 requested a review from a team as a code owner September 6, 2024 14:42
@mds1 mds1 requested a review from Inphi September 6, 2024 14:42
blmalone
blmalone approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@blmalone blmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, some questions and small nits.

packages/contracts-bedrock/test/libraries/Blueprint.t.sol Show resolved Hide resolved
packages/contracts-bedrock/src/libraries/Blueprint.sol Show resolved Hide resolved
packages/contracts-bedrock/test/libraries/Blueprint.t.sol Show resolved Hide resolved
packages/contracts-bedrock/test/libraries/Blueprint.t.sol Show resolved Hide resolved
@mds1 mds1 enabled auto-merge September 6, 2024 17:51
@mds1 mds1 added this pull request to the merge queue Sep 6, 2024
Merged via the queue into develop with commit afcc51a Sep 6, 2024
56 checks passed
@mds1 mds1 deleted the test/blueprints branch September 6, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blmalone blmalone blmalone approved these changes

@Inphi Inphi Awaiting requested review from Inphi Inphi is a code owner automatically assigned from ethereum-optimism/contract-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mds1 @blmalone