Catch 'header not found' string in L2BlockRefByLabel
#11759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
protolambda
approved these changes
Sep 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
via the queue into
ethereum-optimism:develop
with commit Sep 6, 2024
75c7326
55 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
'header not found'to list of EL RPC errors caught byL2BlockRefByLabel.Tests
Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.
Additional context
Geth sometimes returns
'header not found'and sometimes'block not found'. The distinction isn't apparent. Reth has defaulted to returning'header not found', which better describes the root of the error in the reth code.Metadata
'header not found'`https://github.com/ethereum/go-ethereum/blob/623b17ba20daea8cfd2530dd906fda0193b79579/eth/api_backend.go#L204
'block not found'https://github.com/ethereum/go-ethereum/blob/623b17ba20daea8cfd2530dd906fda0193b79579/eth/api_backend.go#L134-L136