fix: flake tests #11742
Merged
fix: flake tests #11742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skeletor-spaceman
approved these changes
Sep 4, 2024
tynes
approved these changes
Sep 4, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* fix: add optimism mintable check on assume address helper * fix: mock interfaces checks * chore: remove unused import --------- Co-authored-by: 0xng <[email protected]>
skeletor-spaceman
removed this pull request from the merge queue due to a manual request
Merged
via the queue into
ethereum-optimism:develop
with commit Sep 4, 2024
f63cba6
55 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes flaky tests caused by incorrect mocking and expect of
supportInterface().Tests
Fix the
_setupLegacyToSuperand the_setupSuperToLegacyhelper functions onL2StandardBridgeInterop.t.solfile.Additional context
https://app.circleci.com/pipelines/github/ethereum-optimism/optimism/63013/workflows/9ff875f0-4bc9-4b04-87c3-066d68f2ee80/jobs/2619982