challenger: Introduce StateConverter to abstract loading VM states #11715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
requested review from
tynes and
Inphi
and removed request for
tynes
ajsutton
force-pushed
the
aj/no-parse-cannon-state
branch
from
9fa3755
to
5536ab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracts a VM-agnostic implementation of
PrestateProviderthat can be shared between cannon and asterisc. The actual state parsing required by it and generating proofs in the TraceProvider is now provided by aStateConverter. Importantly the parsed state is never returned from theStateConverteronly the more generic data that's required, making code much more agnostic to the particular state format.Tests
Refactoring covered by existing tests.