-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interop: interopgen v2 using OPSM #11702
Conversation
349c1c0
to
c26f7c1
Compare
0a3828f
to
0f67553
Compare
0f67553
to
1672528
Compare
Wondering if some of this should be deduplicated with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some naming suggestions, but no blocking comments. I use this branch already in interop-e2e
so I am familiar with the fact that it works.
Semgrep found 6
Named return arguments to functions must be appended with an underscore ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me, just wondering thoughts on the future of this package, will we try to deduplicate things and how do we move towards a world where its more single source of truth/generic so that we don't need to couple L1 contract additions to modifying Go code
Merging this, to unblock op-e2e interop work. Still open to changing a bunch of things, like config approach (separate API layer or not), and more polish. For now though, devnet has priority. |
Description
Changes:
L2Genesis.s.sol
SetPreinstalls
part out of L2 genesis, so we can apply the preinstalls also to the L1 dev genesis.SystemConfigInterop.sol
to not try toinitialize
twice.SystemConfigImpl
address labelinteropgen/deployers
package: reusable functions, to apply an input to a script host, and get a deployment output. Split into OPSM implementations deployment, superchain deployment, L2 chain deployment to L1, creation of L2 genesis, and preinstalls.Tests
Introduce new
op-e2e
test that:This setup can then be used in interop e2e tests, devnet, etc.
Metadata
Fix #11493