feat: concurrent alt-da requests #11698
Merged
+378
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test(batcher): add e2e test for concurrent altda requests doc: add explanation comment for FakeDAServer chore: fix if condition in altda sendTransaction path feat: add maxConcurrentDaRequests config flag + semaphore refactor: batcher to use errgroup for da instead of separate semaphore/waitgroup fix: nil pointer bug after using wrong function after rebase fix: defn of maxConcurrentDaRequests=0 fix: TestBatcherConcurrentAltDARequests chore: remove unneeded if statement around time.Sleep refactor: use TryGo instead of Go to make logic local and easier to read chore: clean up some comments in batcher chore: make batcher shutdown cancel pending altda requests by using shutdownCtx instead of killCtx
samlaf
changed the title
|
This is extremely well thought through, thank you @samlaf for this! @sebastianst is the main owner of the batcher right now |
tynes
reviewed
Aug 30, 2024
tynes
reviewed
Aug 30, 2024
|
@roberto-bayardo could also be a good person to help with review here |
|
Generally looks good to me although I do not own this code |
sebastianst
requested changes
Sep 2, 2024
axelKingsley
reviewed
Sep 3, 2024
sebastianst
reviewed
Sep 4, 2024
|
@sebastianst just realized I was not initializing |
sebastianst
approved these changes
Sep 11, 2024
Merged
via the queue into
ethereum-optimism:develop
with commit Sep 11, 2024
88b1a95
56 checks passed
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the simplest possible implementation to fix the non-blocking da requests. We build off of @karlb's celo-org#213. We use an errgroup for da requests, with its own limit to the number of concurrent goroutines. See https://hackmd.io/@samlaf/op-batcher-concurrent-altda-requests-design-doc for more details.
Testing
We added a basic e2e test by using a fakeDaServer that sleeps for 5 seconds before returning commitments, in order to simulate slow EigenDA responses.
We also tested this manually by running the devnet and submitting large txs and observing the behavior.
Open Questions
(see https://hackmd.io/@samlaf/op-batcher-concurrent-altda-requests-design-doc#Open-questions for working links)