-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: initialization tests #11674
Merged
Merged
fix: initialization tests #11674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartcontracts
force-pushed
the
sc/fix-initialize-test
branch
2 times, most recently
from
August 29, 2024 21:47
34e0ef5
to
b1335e2
Compare
smartcontracts
commented
Aug 29, 2024
smartcontracts
commented
Aug 29, 2024
smartcontracts
commented
Aug 29, 2024
smartcontracts
commented
Aug 29, 2024
smartcontracts
force-pushed
the
sc/fix-initialize-test
branch
from
August 29, 2024 22:21
b1335e2
to
6a732a6
Compare
tynes
reviewed
Sep 3, 2024
smartcontracts
force-pushed
the
sc/fix-initialize-test
branch
2 times, most recently
from
September 4, 2024 22:48
14b2bd8
to
4072a74
Compare
mds1
reviewed
Sep 5, 2024
mds1
reviewed
Sep 5, 2024
mds1
reviewed
Sep 5, 2024
mds1
reviewed
Sep 5, 2024
mds1
reviewed
Sep 5, 2024
mds1
reviewed
Sep 5, 2024
mds1
reviewed
Sep 5, 2024
mds1
reviewed
Sep 5, 2024
mds1
reviewed
Sep 5, 2024
smartcontracts
force-pushed
the
sc/fix-initialize-test
branch
from
September 5, 2024 18:24
4072a74
to
01c76e3
Compare
smartcontracts
force-pushed
the
sc/fix-initialize-test
branch
from
September 5, 2024 18:52
01c76e3
to
0a7726f
Compare
mds1
approved these changes
Sep 5, 2024
Fixes the initialization tests, existing tests were not properly verifying that all of the initializable contracts were being accounted for.
smartcontracts
force-pushed
the
sc/fix-initialize-test
branch
from
September 5, 2024 19:51
0a7726f
to
e70095b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the initialization tests, existing tests were not properly verifying that all of the initializable contracts were being accounted for.