op-batcher/batcher: check txpool state in state publishing loop #11633
+45
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberto-bayardo
force-pushed
the
txpool-state-fixes
branch
2 times, most recently
from
7559a93
to
027e309
Compare
roberto-bayardo
force-pushed
the
txpool-state-fixes
branch
2 times, most recently
from
28746e1
to
6fa5b69
Compare
sebastianst
reviewed
Aug 29, 2024
- protect txpool state vars with a mutex so they can be automically updated to avoid potential race condition
roberto-bayardo
force-pushed
the
txpool-state-fixes
branch
from
6fa5b69
to
e7e0da2
Compare
sebastianst
approved these changes
Aug 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
ethereum-optimism:develop
with commit Aug 29, 2024
7373ce7
56 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make state publishing loop abort if the txpool state is not good to prevent this loop from getting stuck due to blob and calldata transactions flip flopping and cancelling each other out.
protect txpool state vars with a mutex so they can be atomically updated to avoid potential race condition.
Tests
Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.
Additional context
Add any other context about the problem you're solving.
Metadata