feat(op-challenger): Refactor out Global Config #11309
Conversation
There was a problem hiding this comment.
Its been a while so not sure how well this lines up with my original comments, but looking at it with fresh eyes, my suggestion would be to simplify things this way: #11348
Then we maintain a single vm.Config and just have a helper object that we plug in to calculate the arguments required for the oracle server execution which is really all we're trying to do.
| } | ||
|
|
||
| var _ VmConfig = (*KonaVmConfig)(nil) | ||
|
|
||
| func NewKonaVmConfig(vmConfig Config) *KonaVmConfig { | ||
| func NewKonaVmConfig(cfg *Config) *KonaVmConfig { |
There was a problem hiding this comment.
We've been pretty consistent in passing around vm.Config directly instead of via a pointer - would be good to stick with that since it's a pretty small object. Will save adding & in a lot of places in this PR.
| func (s *OpProgramVmConfig) Cfg() Config { | ||
| return s.Config | ||
| } | ||
|
|
||
| func (s *OpProgramVmConfig) FillHostCommand(args []string, dataDir string, inputs utils.LocalGameInputs) ([]string, error) { | ||
| if args == nil { | ||
| return nil, errors.New("args is nil") | ||
| } | ||
|
|
||
| args = append(args, | ||
| "--", |
There was a problem hiding this comment.
I'd still say that this should be added by the executor not the program.
Description
Refactors the global
Configtype out of theVmConfig. Although this duplicates a bit of Config fields, they will be consistent since theVmConfigis constructed using theConfigobject.This is a minimal change so we don't need to further refactor the challenger's top-level
config.Configobject (adding new fields for variousVmConfigs).