Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(devnet-tasks): add complete and editable tests #11177

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

nidz-the-fact
Copy link
Contributor

Description

Update: Added .env (dotenv) helper and sepolia network for testing to allow developers to test better.

Tests

Configuring (external) development environment for devnet testing.
image

Additional context

Use external configuration By adjusting the .example.env file, remove .example and configure it in .env (referenced with hardhat in hardhat.config.ts).

Metadata

  • Fixes #[Link to Issue] none

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.64%. Comparing base (f5221f4) to head (924020f).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11177      +/-   ##
===========================================
+ Coverage    62.58%   62.64%   +0.05%     
===========================================
  Files           21       21              
  Lines         1935     1938       +3     
  Branches        71       73       +2     
===========================================
+ Hits          1211     1214       +3     
  Misses         687      687              
  Partials        37       37              
Flag Coverage Δ
cannon-go-tests 80.21% <ø> (ø)
chain-mon-tests 27.14% <ø> (ø)
sdk-tests 16.91% <100.00%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/devnet-tasks/hardhat.config.ts 100.00% <100.00%> (ø)

Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine to merge although this package is temporary and not guaranteed to always work. We will delete this package in the future.

@tynes tynes added this pull request to the merge queue Jul 18, 2024
Merged via the queue into ethereum-optimism:develop with commit 5be9141 Jul 18, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants