Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannon: Refactor instrumented_state.go to extract reusable helpers #11174

Conversation

mbaxter
Copy link
Contributor

@mbaxter mbaxter commented Jul 17, 2024

Description

Refactor instrumented_state.go to extract reusable helpers that will be useful for MTCannon.

Tests

This is just refactor, so existing tests should provide coverage.

Metadata

Part of: #11642

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 51.30435% with 56 lines in your changes missing coverage. Please review.

Project coverage is 64.08%. Comparing base (4584c97) to head (8e0ba04).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11174      +/-   ##
===========================================
- Coverage    64.41%   64.08%   -0.34%     
===========================================
  Files           27       30       +3     
  Lines         2147     2166      +19     
  Branches        71       71              
===========================================
+ Hits          1383     1388       +5     
- Misses         717      731      +14     
  Partials        47       47              
Flag Coverage Δ
cannon-go-tests 79.70% <51.30%> (-0.63%) ⬇️
chain-mon-tests 27.14% <ø> (ø)
sdk-tests 16.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cannon/mipsevm/exec/mips_instructions.go 97.84% <100.00%> (ø)
cannon/mipsevm/exec/mips_syscalls.go 93.33% <100.00%> (ø)
cannon/mipsevm/memory/memory.go 82.89% <100.00%> (ø)
cannon/mipsevm/singlethreaded/mips.go 94.00% <100.00%> (+24.47%) ⬆️
cannon/mipsevm/exec/memory.go 84.61% <84.61%> (ø)
cannon/mipsevm/exec/preimage.go 70.96% <70.96%> (ø)
cannon/mipsevm/singlethreaded/instrumented.go 57.37% <54.54%> (+0.02%) ⬆️
cannon/mipsevm/exec/stack.go 5.40% <5.40%> (ø)

@mbaxter mbaxter force-pushed the cp-903/offchain-mtcannon/refactor-instrumented-state branch from 06642d3 to 8e0ba04 Compare July 18, 2024 15:12
@mbaxter mbaxter requested a review from Inphi July 18, 2024 15:48
@mbaxter mbaxter marked this pull request as ready for review July 18, 2024 15:48
@mbaxter mbaxter requested a review from a team as a code owner July 18, 2024 15:48
cannon/mipsevm/exec/memory.go Show resolved Hide resolved
@mbaxter mbaxter added this pull request to the merge queue Jul 19, 2024
Merged via the queue into ethereum-optimism:develop with commit 8b910d7 Jul 19, 2024
60 checks passed
@mbaxter mbaxter deleted the cp-903/offchain-mtcannon/refactor-instrumented-state branch July 19, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants