Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10785 +/- ##
============================================
+ Coverage 59.46% 79.96% +20.49%
============================================
Files 19 11 -8
Lines 1658 1123 -535
Branches 71 0 -71
============================================
- Hits 986 898 -88
+ Misses 640 193 -447
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. |
pcw109550
reviewed
Jun 11, 2024
mbaxter
approved these changes
Jun 11, 2024
Contributor
mbaxter
left a comment
mbaxter
left a comment
There was a problem hiding this comment.
lgtm - just a few questions + looks like there's a merge conflict
rdovgan
pushed a commit
to rdovgan/optimism
that referenced
this pull request
Jun 24, 2024
* challenger: Create generic vm executor and use for asterisc * challenger: Move executor utils to vm package * challenger: Switch cannon to use common vm executor. * challenger: Use vm.Config to encapsulate Cannon config items. * challenger: Rename to include Path * challenger: Use vm.Config to encapsulate Asterisc config items. * challenger: Remove unused interface * challenger: Reduce amount of config passed to cannon/asterisc trace providers * challenger: Remove Config from names * challenger: Remove replaced cannon metrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deduplicate the executor code for cannon and asterisc. Previously they only varied by the
AsteriscorCannonconfig items. Now there's avm.Configwhich can be reused for both VMs and still allow having different config for each.Tests
Updated unit tests.
Metadata