op-e2e: Fix flake by using waiter instead of getting safe block directly#10753
Merged
op-e2e: Fix flake by using waiter instead of getting safe block directly#10753
Conversation
Contributor
Author
|
Not finding the precompile we expect being accessed so this doesn't fix things for some reason. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10753 +/- ##
============================================
+ Coverage 54.65% 79.60% +24.95%
============================================
Files 37 10 -27
Lines 2944 1123 -1821
Branches 415 0 -415
============================================
- Hits 1609 894 -715
+ Misses 1303 197 -1106
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
Author
|
The failure I had locally is because I've wound up using go 1.22 which breaks cannon so that's not related. Have triggered a run of the cannon tests in CI to see if they pass there now. |
Contributor
Author
|
Confirmed tests are passing in CI. |
ajsutton
requested review from
Inphi and
protolambda
and removed request for
bitwiseguy
Inphi
approved these changes
Jun 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rdovgan
pushed a commit
to rdovgan/optimism
that referenced
this pull request
Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a flake in the cannon e2e tests because op-geth sometimes returns not found for the safe block, so use a waiter to ensure it is available.