e2e: Convert more fault proof tests to use the custom contract bindings#10716
Merged
e2e: Convert more fault proof tests to use the custom contract bindings#10716
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10716 +/- ##
============================================
+ Coverage 54.65% 79.60% +24.95%
============================================
Files 37 10 -27
Lines 2944 1123 -1821
Branches 415 0 -415
============================================
- Hits 1609 894 -715
+ Misses 1303 197 -1106
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. |
ajsutton
force-pushed
the
aj/convert-more-contracts
branch
from
293be8e to
a1466fd
Compare
ajsutton
requested review from
Inphi and
protolambda
and removed request for
protolambda
refcell
approved these changes
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes more dependencies on the generated fault dispute game bindings.
Introduces new helper functions to send a txmgr TxCandidate rather than depending on the generated bindings to estimate gas etc.