Conversation
karlfloersch
approved these changes
Apr 26, 2020
snario
pushed a commit
that referenced
this pull request
Apr 14, 2021
protolambda
added a commit
to protolambda/optimism
that referenced
this pull request
May 1, 2022
…-yarn-build Add a build command to package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR adds support for propagating internal EVM error messages up to the OVM caller for both
eth_callandeth_sendTransactionWe previously were able to accomplish this by having the EM's event logs indicate reverts, but not having the internal transactions themselves revert. Now that we are not waiting for transactions to be mined, we had to go back to the model where a reverting OVM transaction reverts the internal EVM transaction, too. This adds a bit of complication for receipts, but it's manageable.
Also incorporates some random bugfixes from a hotfix branch of @K-Ho 's.
Questions
allowRevertfrom EM which appears to be only ever set to true? My bias is towards leaving it for now as we may need to change things up again in the future.Metadata
Fixes
Contributing Agreement