Skip to content

Surfacing revert messages for eth_call and eth_sendRawTransaction#107

Merged
ben-chain merged 9 commits intomasterfrom
feat/YAAS-328/sendRawTransaction-error-handling
Apr 26, 2020
Merged

Surfacing revert messages for eth_call and eth_sendRawTransaction#107
ben-chain merged 9 commits intomasterfrom
feat/YAAS-328/sendRawTransaction-error-handling

Conversation

@ben-chain
Copy link
Collaborator

@ben-chain ben-chain commented Apr 24, 2020

Description

PR adds support for propagating internal EVM error messages up to the OVM caller for both eth_call and eth_sendTransaction

We previously were able to accomplish this by having the EM's event logs indicate reverts, but not having the internal transactions themselves revert. Now that we are not waiting for transactions to be mined, we had to go back to the model where a reverting OVM transaction reverts the internal EVM transaction, too. This adds a bit of complication for receipts, but it's manageable.

Also incorporates some random bugfixes from a hotfix branch of @K-Ho 's.

Questions

  • Should we remove allowRevert from EM which appears to be only ever set to true? My bias is towards leaving it for now as we may need to change things up again in the future.

Metadata

Fixes

  • Fixes YAS 328

Contributing Agreement

@ben-chain ben-chain changed the title [WIP] Revert message handling for EVM transactions Surfacing revert messages for eth_call and eth_sendRawTransaction Apr 25, 2020
Copy link
Contributor

@karlfloersch karlfloersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is DOPE. LGTMLGTMLGTMLGTMLGTMLGTMLGTMLGTMLGTMLGTM.

(I did add a quick test here to make sure the nonce increments but generally very excited that we will have the right behavior now it seems)

@ben-chain ben-chain merged commit 9d67507 into master Apr 26, 2020
@gakonst gakonst deleted the feat/YAAS-328/sendRawTransaction-error-handling branch March 18, 2021 15:01
snario pushed a commit that referenced this pull request Apr 14, 2021
protolambda added a commit to protolambda/optimism that referenced this pull request May 1, 2022
…-yarn-build

Add a build command to package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants