op-challenger: Actually use the prestate downloaded from URL when executing#10650
Merged
op-challenger: Actually use the prestate downloaded from URL when executing#10650
Conversation
ajsutton
requested review from
Inphi and
sebastianst
and removed request for
sebastianst
Inphi
approved these changes
May 24, 2024
Contributor
Inphi
left a comment
Inphi
left a comment
There was a problem hiding this comment.
Looks good. The registerAsterisc should also be updated to use the prestate source.
Contributor
Author
Yep agreed, will follow up with that. |
… when executing. (#10651)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10650 +/- ##
============================================
+ Coverage 55.13% 81.92% +26.78%
============================================
Files 37 10 -27
Lines 2900 1079 -1821
Branches 415 0 -415
============================================
- Hits 1599 884 -715
+ Misses 1269 163 -1106
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Jun 6, 2024
rdovgan
pushed a commit
to rdovgan/optimism
that referenced
this pull request
Jun 24, 2024
…cuting (ethereum-optimism#10650) * op-challenger: Actually use the prestate downloaded from URL when executing. * op-challenger: Actually use the asterisc prestate downloaded from URL when executing. (ethereum-optimism#10651)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Actually use the prestate downloaded from URL when executing rather than the hard coded single file.