ctb: SafeTestTools improvements

[maurelian]

Description

Implemented a new feature allowing the saltNonce in the SafeTestTools contracts to be overriden, preventing create2 collisions.

This was necessary to address an issue in the LivenessGuard tests which seems to have suddenly started occurring.

[maurelian]

• ctb: Add new OwnerRemovalFailed(string) error type to LM #10538
• ctb: Move threshold check from LivenessModule constructor #10516
• ctb: SafeTestTools improvements #10537 👈
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maurelian and the rest of your teammates on Graphite

[coderabbitai]

Walkthrough

The recent updates aim to enhance the functionality and security of the Safe contracts in the Bedrock package. These changes include the introduction of saltNonce variables to prevent create2 collisions and the implementation of advanced parameters and overloaded functions for setting up Safe instances. These improvements streamline Safe contract management and retrieval, enhancing testing and deployment processes.

Changes

File Path	Change Summary
.../test/Safe/LivenessGuard.t.sol	Added saltNonce to prevent collisions in LivenessGuard_FuzzOwnerManagement_Test.
.../test/safe-tools/SafeTestTools.sol	Introduced saltNonce, enhanced _setupSafe with advanced parameters, added overloaded _setupSafe functions, and new getSafe functions for retrieving Safe instances.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 6

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.22%. Comparing base (78e1084) to head (070c141).
Report is 1 commits behind head on develop.

❗ Current head 070c141 differs from pull request most recent head 93d1655. Consider uploading reports for the commit 93d1655 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #10537       +/-   ##
============================================
- Coverage    42.35%   29.22%   -13.13%     
============================================
  Files           73       31       -42     
  Lines         4838     2898     -1940     
  Branches       766      614      -152     
============================================
- Hits          2049      847     -1202     
+ Misses        2681     1976      -705     
+ Partials       108       75       -33     

Flag	Coverage Δ
cannon-go-tests	?
chain-mon-tests	27.14% <ø> (ø)
common-ts-tests	?
contracts-ts-tests	12.25% <ø> (ø)
core-utils-tests	?
sdk-tests	40.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 42 files with indirect coverage changes

[maurelian]

Merge activity

• May 14, 5:08 PM EDT: Graphite failed to merge this pull request due to This repository has GitHub's merge queue enabled, which is currently incompatible with Graphite. Try your merge again, or report a bug if you see this consistently.