ctb: Change Safe contract version to GnosisSafe v1.3.0

[maurelian]

Description

Reduces the safe version to 1.3.0, which matches the current SC safe.

This changes the naming from Safe to GnosisSafe, but I have overriden the name in the imports (ie. import { GnosisSafe as Safe} in order to minimize the diff.

[coderabbitai]

Walkthrough

Walkthrough

The updates across the contracts-bedrock package primarily involve renaming and reorganizing import paths within the safe-contracts library. Key changes include renaming Safe to GnosisSafe and updating associated references in various scripts and tests. Additionally, there are alterations in the import paths for entities like OwnerManager, ModuleManager, and GuardManager, reflecting a broader restructure of the safe-contracts package.

Changes

Files Affected	Summary of Changes
.../lib/safe-contracts, .../scripts/Deploy.s.sol, .../scripts/DeployOwnership.s.sol, .../src/Safe/DeputyGuardianModule.sol, .../src/Safe/LivenessModule.sol, .../test/Safe/DeputyGuardianModule.t.sol, .../test/Safe/LivenessModule.t.sol, .../test/safe-tools/CompatibilityFallbackHandler_1_3_0.sol	Renamed Safe to GnosisSafe. Updated import paths.
.../src/Safe/LivenessGuard.sol, .../test/Safe/LivenessGuard.t.sol	Updated import paths for GnosisSafe, removed ModuleManager and SafeProxyFactory, added OwnerManager.
.../test/Safe/SafeSigners.t.sol	Changed import of Safe to GnosisSafe, removed SignatureDecoder.
.../test/safe-tools/SafeTestTools.sol	Reorganized imports for GnosisSafe, OwnerManager, ModuleManager, GuardManager, GnosisSafeProxyFactory, and SignMessageLib. Updated paths within safe-contracts.

---

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2258686 and 39d3c00.

Files ignored due to path filters (4)

• packages/contracts-bedrock/semver-lock.json is excluded by !**/*.json
• packages/contracts-bedrock/snapshots/abi/DeputyGuardianModule.json is excluded by !**/*.json
• packages/contracts-bedrock/snapshots/abi/LivenessGuard.json is excluded by !**/*.json
• packages/contracts-bedrock/snapshots/abi/LivenessModule.json is excluded by !**/*.json

Files selected for processing (14)

• packages/contracts-bedrock/lib/safe-contracts (1 hunks)
• packages/contracts-bedrock/scripts/Deploy.s.sol (1 hunks)
• packages/contracts-bedrock/scripts/DeployOwnership.s.sol (1 hunks)
• packages/contracts-bedrock/src/Safe/DeputyGuardianModule.sol (1 hunks)
• packages/contracts-bedrock/src/Safe/LivenessGuard.sol (1 hunks)
• packages/contracts-bedrock/src/Safe/LivenessModule.sol (1 hunks)
• packages/contracts-bedrock/test/Safe/DeployOwnership.t.sol (1 hunks)
• packages/contracts-bedrock/test/Safe/DeputyGuardianModule.t.sol (1 hunks)
• packages/contracts-bedrock/test/Safe/LivenessGuard.t.sol (1 hunks)
• packages/contracts-bedrock/test/Safe/LivenessModule.t.sol (1 hunks)
• packages/contracts-bedrock/test/Safe/SafeSigners.t.sol (1 hunks)
• packages/contracts-bedrock/test/kontrol/proofs/utils/DeploymentSummaryCode.sol (1 hunks)
• packages/contracts-bedrock/test/safe-tools/CompatibilityFallbackHandler_1_3_0.sol (1 hunks)
• packages/contracts-bedrock/test/safe-tools/SafeTestTools.sol (1 hunks)

Files not summarized due to errors (1)

• packages/contracts-bedrock/test/kontrol/proofs/utils/DeploymentSummaryCode.sol: Error: Message exceeds token limit

Files skipped from review as they are similar to previous changes (12)

• packages/contracts-bedrock/lib/safe-contracts
• packages/contracts-bedrock/scripts/Deploy.s.sol
• packages/contracts-bedrock/scripts/DeployOwnership.s.sol
• packages/contracts-bedrock/src/Safe/DeputyGuardianModule.sol
• packages/contracts-bedrock/src/Safe/LivenessGuard.sol
• packages/contracts-bedrock/src/Safe/LivenessModule.sol
• packages/contracts-bedrock/test/Safe/DeputyGuardianModule.t.sol
• packages/contracts-bedrock/test/Safe/LivenessGuard.t.sol
• packages/contracts-bedrock/test/Safe/LivenessModule.t.sol
• packages/contracts-bedrock/test/Safe/SafeSigners.t.sol
• packages/contracts-bedrock/test/safe-tools/CompatibilityFallbackHandler_1_3_0.sol
• packages/contracts-bedrock/test/safe-tools/SafeTestTools.sol

Additional comments not posted (3)

packages/contracts-bedrock/test/Safe/DeployOwnership.t.sol (1)

13-13: Renaming Safe to GnosisSafe aligns with the PR objectives and enhances consistency with the latest contract version.

packages/contracts-bedrock/test/kontrol/proofs/utils/DeploymentSummaryCode.sol (2)

8-8: Ensure the hexadecimal string for safeProxyFactoryCode is correctly formatted and represents valid EVM bytecode.

---

10-10: Ensure the hexadecimal string for safeSingletonCode is correctly formatted and represents valid EVM bytecode.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[maurelian]

• ctb: Move threshold check from LivenessModule constructor #10516
• ctb: Change Safe contract version to GnosisSafe v1.3.0 #10515 👈
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maurelian and the rest of your teammates on Graphite

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.22%. Comparing base (45e1bd2) to head (39d3c00).
Report is 4 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #10515       +/-   ##
============================================
- Coverage    42.31%   29.22%   -13.09%     
============================================
  Files           73       31       -42     
  Lines         4838     2898     -1940     
  Branches       766      614      -152     
============================================
- Hits          2047      847     -1200     
+ Misses        2682     1976      -706     
+ Partials       109       75       -34     

Flag	Coverage Δ
cannon-go-tests	?
chain-mon-tests	27.14% <ø> (ø)
common-ts-tests	?
contracts-ts-tests	12.25% <ø> (ø)
core-utils-tests	?
sdk-tests	40.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 42 files with indirect coverage changes