op-challenger: Integrate challenging L2 block numbers#10446
Merged
Conversation
Add rollupEndpoint to NewConfig signature since it was already always required.
ajsutton
requested review from
Inphi and
axelKingsley
and removed request for
a team and
axelKingsley
refcell
approved these changes
May 8, 2024
Contributor
refcell
left a comment
refcell
left a comment
There was a problem hiding this comment.
Very nice scaffolding, this puts us in a really good spot.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates op-challenger logic to check if the l2 block number has been challenged before participating in a game (ignore game if it has been successfully challenged) and to check if the l2 block number can be challenged before playing.
The actual contract bindings are currently just setup for compatibility with the existing contracts which don't support directly challenging the l2 block number. This should result in no change in behaviour. Once the contract changes land a follow up PR can add support for actually calling the new functions.
Builds on #10445
Tests
Updated unit tests. e2e tests should confirm backwards compatibility works...
Metadata