Conversation
Removes the need to specify the L1 chainid via CLI. Follows similar patterns to L2 genesis generation that were done recently. Follow up PRs can potentially use the same sort of deployer pattern as in #10343 for when doing the L1 genesis dump to remove the need to specify the private key.
Remove the concept of implicit deploy config for explicit deploy config. This removes confusing implicit behavior as well as makes it much more straight forward for deploying multiple superchain targets to the same L1. This is a breaking change but the error message makes it very obvious and the docs are being updated in a way that should include this information.
The `name()` function existed due to legacy purposes when dealing with hardhat artifacts and no longer is necessary. This commit removes it in favor of a simpler approach of just using the chainid instead of the name. The files that are written are not committed into the repo.
WalkthroughWalkthroughThe recent updates focus on enhancing script execution and configuration management system-wide. Changes include adding new environment variables for deployment, updating logging and file handling strategies, and simplifying deployment interfaces by removing specific artifacts in scripts. Changes
Recent Review DetailsConfiguration used: .coderabbit.yml Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
This PR exists to improve the devex of using the deploy script so that its always expected to provide the deploy config path as an env var when running the deploy script |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Out of diff range and nitpick comments (4)
bedrock-devnet/devnet/__init__.py (4)
Line range hint
7-7: Consider removing the unused importcalendar.- import calendar
Line range hint
12-12: Thegzipmodule is imported but not used in this file. It should be removed unless planned for future use.- import gzip
Line range hint
18-18: The importdevnet.log_setupis unused. It should be removed to clean up the code.- import devnet.log_setup
Line range hint
223-223: Replace direct boolean comparisons with more idiomatic Python expressions.- if os.path.exists(l2_allocs_path) == False or DEVNET_FPAC == True: - if not os.path.exists(l2_allocs_path) or DEVNET_FPAC:
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10359 +/- ##
============================================
- Coverage 42.33% 29.22% -13.11%
============================================
Files 73 31 -42
Lines 4845 2898 -1947
Branches 766 614 -152
============================================
- Hits 2051 847 -1204
+ Misses 2684 1976 -708
+ Partials 110 75 -35
Flags with carried forward coverage won't be shown. Click here to find out more. |
ghost
mentioned this pull request
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (5)
bedrock-devnet/devnet/__init__.py (5)
Line range hint
7-7: Remove unused importcalendar.- import calendar
Line range hint
12-12: Remove unused importgzip.- import gzip
Line range hint
18-18: Remove unused importdevnet.log_setup.- import devnet.log_setup
Line range hint
222-222: Refactor the condition checks to use more Pythonic expressions.- if os.path.exists(l2_allocs_path) == False or DEVNET_FPAC == True: + if not os.path.exists(l2_allocs_path) or DEVNET_FPAC:
Line range hint
311-311: Remove the unused local variablee.- except Exception as e: + except Exception:
packages/contracts-bedrock/test/kontrol/scripts/make-summary-deployment.sh
Show resolved
Hide resolved
Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
3 participants
Description
Deletes dead code and simplifies the deploy script
infrastructure to make it less error prone and more
explicit.