contracts-bedrock: remove cannon deps on bindings#10280
Conversation
Removes `cannon` deps on `op-bindings` package following a pattern similar to #10225. Includes test coverage of the new functions and is the minimal diff to get things working. Ideally there was a canonical forge artifact type that is used but for now we don't worry about it. This unblocks further work on removing the bindings from the monorepo, greatly improving devex.
|
Warning Rate Limit Exceeded@tynes has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 41 minutes and 21 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe changes across the codebase streamline contract loading processes and enhance workflow efficiency. The update in Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (2)
cannon/mipsevm/evm.go (2)
24-33: Consider using configuration or environment variables for JSON file paths to enhance portability and flexibility.
40-51: Consider adding logging at key steps to improve traceability and debugging, especially useful in production environments.
|
cannon fuzz + cannon go lint need to wait for contracts build now |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10280 +/- ##
===========================================
- Coverage 42.40% 42.33% -0.07%
===========================================
Files 73 73
Lines 4830 4845 +15
Branches 766 766
===========================================
+ Hits 2048 2051 +3
- Misses 2676 2684 +8
- Partials 106 110 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2 participants
Description
Removes
cannondeps onop-bindingspackage followinga pattern similar to #10225.
Includes test coverage of the new functions and is the minimal diff to
get things working.
Ideally there was a canonical forge artifact type that is used but for
now we don't worry about it. This unblocks further work on removing the
bindings from the monorepo, greatly improving devex.