core/txpool: Support journaling remote transactions with --txpool.journalremotes#97
Merged
protolambda merged 1 commit intooptimismfrom Jun 2, 2023
Merged
core/txpool: Support journaling remote transactions with --txpool.journalremotes#97protolambda merged 1 commit intooptimismfrom
protolambda merged 1 commit intooptimismfrom
Conversation
ajsutton
force-pushed
the
aj/journal-remote
branch
from
b262c84 to
d619a93
Compare
protolambda
approved these changes
Jun 2, 2023
Contributor
protolambda
left a comment
protolambda
left a comment
There was a problem hiding this comment.
Changes look good to me. The flag description can maybe expand on loading-as-remote behavior for previously local txs, but the comments explain it well enough, and when it combines with txpool.nolocals there are no price exemption edge-cases anyway.
gd-0
pushed a commit
to gattaca-com/based-op-geth
that referenced
this pull request
May 19, 2025
Co-authored-by: ilitteri <ilitteri@fi.uba.ar>
gd-0
pushed a commit
to gattaca-com/based-op-geth
that referenced
this pull request
May 19, 2025
Co-authored-by: ilitteri <ilitteri@fi.uba.ar>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
--txpool.journalremotesoption that ensures all transactions are written to the journal (if enabled) instead of only local ones. When reloading transactions after a restart all loaded transactions are treated as remote.This is designed to be used with
--txpools.nolocalswhere there are no local transactions but its desirable to have the transaction pool content preserved across restarts.Metadata