remove storedReceiptsRLP struct#738
Merged
joshklop merged 6 commits intojoshklop/v1.16.5from Dec 20, 2025
Merged
Conversation
Add multiple raw DB receipt hex test vectors and iterate over them using t.Run to create subtests. Decode each receipt inside the subtest and remove hardcoded assertions. Add fmt import.
Replace the local storedReceiptRLP with core/types.ReceiptForStorage in decoding code. Update tests to decode into ReceiptForStorage and compare FeeScalar as a big.Float. Use ReceiptForStorage, remove duplicate struct Mark legacy receipt fields as rlp:"optional" so mixed-format receipts can be parsed without errors. Update unit tests to decode legacy receipts into ReceiptForStorage and compare FeeScalar by parsing it into a big.Float to match the stored representation
joshklop
added a commit
that referenced
this pull request
Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supersedes #735