Skip to content

interop: Fix InteropClient Close routine.#426

Merged
protolambda merged 1 commit intointerop-sequencer-checkfrom
interop-sequencer-check-fix-close
Oct 31, 2024
Merged

interop: Fix InteropClient Close routine.#426
protolambda merged 1 commit intointerop-sequencer-checkfrom
interop-sequencer-check-fix-close

Conversation

@ghost
Copy link

@ghost ghost commented Oct 31, 2024

Description

Fixes InteropClient shutdown behavior to call Close() on the underlying client instead of calling it on itself.

Additional context

Resolves a noticed issue with tests in the monorepo that wouldn't stop.

Metadata

Fixed as part of ethereum-optimism/optimism#12754

@ghost ghost self-requested a review as a code owner October 31, 2024 09:37
@ghost ghost requested review from ajsutton and protolambda October 31, 2024 09:37
@ghost ghost changed the title Interop sequencer check fix close interop: Fix InteropClient Close routine. Oct 31, 2024
@ghost ghost changed the base branch from optimism to interop-sequencer-check October 31, 2024 13:24
@protolambda protolambda merged commit 56eebc5 into interop-sequencer-check Oct 31, 2024
@protolambda protolambda deleted the interop-sequencer-check-fix-close branch October 31, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants