fix: Only apply effective gas limit when building new blocks #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
approved these changes
Oct 2, 2024
roberto-bayardo
approved these changes
Oct 2, 2024
roberto-bayardo
merged commit 2a8b364
into
ethereum-optimism:optimism
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the behavior of the miner's effective gas limit such that this no longer applies to blocks with the
noTxsflag set.As the effective gas limit is not a consensus property, other nodes must not reject sequenced blocks which contain a greater amount of gas than this "effective" limit, and thus this should only be applied when building blocks containing mempool transactions. Otherwise only the true consensus gas limit should be enforced.
This is an important fix when running multiple sequencers under consensus, as any increase to the effective gas limit on one sequencer may cause the others to reject any blocks with this higher limit and fork off to their own chain.
Tests
Additional context
Metadata