-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: do not trigger rewind behaviour when modifying pre-genesis hardfork times / blocks #332
Conversation
Next steps following sync with @sebastianst
|
|
This is brittle in general and longer term we need a solution that requires less boiler plate.
Done
Done
Done! |
This allows us to handle the case where the genesis itself (and therefore the genesis timestamp) is undefined. We handle that by declaring all time stamps as POST genesis, so they can't pass the compatibilty check via the new escape hatch.
|
Replaces #257
Currently, no Optimism hard forks are checked as a part of this function:
op-geth/params/config.go
Lines 807 to 876 in 0d7fd67
So modifying an optimism hard fork time will not cause a chain rewind, whereas modifying a non-optimism hardfork will cause a chain rewind.
Towards https://github.com/ethereum-optimism/client-pod/issues/918
Counterpart to ethereum-optimism/superchain-registry#260