core/txpool/legacypool: respect nolocals-setting (#28435)#231
Merged
trianglesphere merged 1 commit intooptimismfrom Jan 31, 2024
Merged
core/txpool/legacypool: respect nolocals-setting (#28435)#231trianglesphere merged 1 commit intooptimismfrom
trianglesphere merged 1 commit intooptimismfrom
Conversation
This change adds a check to ensure that transactions added to the legacy pool are not treated as 'locals' if the global locals-management has been disabled. This change makes the pool enforce the --txpool.pricelimit setting.
sebastianst
approved these changes
Jan 31, 2024
Member
sebastianst
left a comment
sebastianst
left a comment
There was a problem hiding this comment.
confirmed this is the upstream fix ethereum/go-ethereum#28435
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds a check to ensure that transactions added to the legacy pool are not treated as 'locals' if the global locals-management has been disabled.
This change makes the pool enforce the --txpool.pricelimit setting.
Tests
This backport PR has tests.
Additional context
This PR or the upstream commit should be removed when #215 is merged.