4844 prep: Add Ecotone fork check & refactor l1 / data availability cost functions by roberto-bayardo · Pull Request #203 · ethereum-optimism/op-geth

roberto-bayardo · 2023-12-15T05:32:37Z

Description

We intend to introduce EIP-4844 support with Ecotone upgrade, which will require the ability to switch L1 data cost functions when Ecotone is activated. This PR adds ability to check if Ecotone is active, and also refactors the L1CostFunc code to allow L1DataCost functions based on transaction properties other than "RollupDataGas". These abstractions also allow removal of some of the duplicated l1 data cost logic within receipts.go.

Tests

Added a unit test to codify behavior of existing cost function & receipt processing.

core/types/transaction.go

mdehoog

nice refactor

core/types/rollup_l1_cost.go

core/state_transition.go

core/types/rollup_l1_cost.go

params/config.go

core/types/receipt.go

core/types/rollup_l1_cost.go

core/state_transition.go

core/types/rollup_cost.go

core/types/rollup_l1_cost.go

core/types/rollup_cost.go

…o swap in new ones

… op-stack config, fix tx-pool l1-cost-func

…ost functions (ethereum-optimism#203) * add Ecotone upgrade getters & refactor L1CostFunc to make it easier to swap in new ones * core: nil instead of zero, always check empty rollup data-cost, check op-stack config, fix tx-pool l1-cost-func --------- Co-authored-by: protolambda <proto@protolambda.com> add Ecotone upgrade getters & refactor L1CostFunc to make it easier to swap in new ones

roberto-bayardo force-pushed the 4844 branch 3 times, most recently from 96d5d88 to 9070c32 Compare December 15, 2023 06:34

protolambda suggested changes Dec 15, 2023

View reviewed changes

core/types/transaction.go Show resolved Hide resolved

roberto-bayardo force-pushed the 4844 branch from 45fad37 to 109a9cf Compare December 15, 2023 15:07

roberto-bayardo marked this pull request as ready for review December 15, 2023 15:11

roberto-bayardo force-pushed the 4844 branch 2 times, most recently from cfcfdb1 to b2ecbf7 Compare December 15, 2023 15:30

roberto-bayardo requested a review from protolambda December 15, 2023 15:32

roberto-bayardo mentioned this pull request Dec 15, 2023

[Fjord] Add FastLZ compression into L1CostFunc #202

Closed

mdehoog reviewed Dec 15, 2023

View reviewed changes

core/types/transaction.go Outdated Show resolved Hide resolved

roberto-bayardo force-pushed the 4844 branch from b2ecbf7 to 94ae9d3 Compare December 15, 2023 18:24

roberto-bayardo requested a review from mdehoog December 15, 2023 18:29

mdehoog approved these changes Dec 15, 2023

View reviewed changes

mdehoog reviewed Dec 15, 2023

View reviewed changes

core/types/rollup_l1_cost.go Outdated Show resolved Hide resolved

roberto-bayardo force-pushed the 4844 branch 3 times, most recently from d85567d to f69c847 Compare December 19, 2023 17:26

roberto-bayardo changed the title ~~4844 prep: Add Eclipse fork check & refactor L1DataCost~~ 4844 prep: Add Ecotone fork check & refactor L1DataCost Dec 19, 2023

roberto-bayardo force-pushed the 4844 branch from f69c847 to 8cefec9 Compare December 19, 2023 17:33