This repository was archived by the owner on Apr 11, 2021. It is now read-only.
Conversation
Contributor
Is it possible that you could open a PR in |
tynes
commented
Mar 12, 2021
| const blockNumber = BigNumber.from(returnData[1]) | ||
|
|
||
| // TODO: this is a bug and needs to be fixed | ||
| //assert.deepEqual(info.ethContext.blockNumber, blockNumber.toNumber()) |
Collaborator
Author
There was a problem hiding this comment.
This is a bug, should be addressed by ethereum-optimism/go-ethereum#271
| }) | ||
|
|
||
| it('should return same timestamp and blocknumbers between `eth_call` and `rollup_getInfo`', async () => { | ||
| // As atomically as possible, call `rollup_getInfo` and OVMMulticall for the |
Contributor
There was a problem hiding this comment.
Needs better explanation of why the atomicity here is necessary.
smartcontracts
approved these changes
Mar 19, 2021
Contributor
|
I think this is fine to merge. Nothing else really blocking here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integration tests for ethereum-optimism/go-ethereum#280
It is expected to fail without the changes in that PR
From optimism integration
From
optimism-integration/integration-testsMetadata
Fixes
Contributing Agreement