feat(proxyd): add config to skip is syncing check #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmvien
changed the title
jelias2
reviewed
Mar 12, 2025
|
@jelias2 thanks for reviewing. I added test. Mind taking another look when you get a chance? |
jelias2
approved these changes
Mar 13, 2025
|
Thanks for the contribution Hien! The latest relase: proxyd/v4.14.3 has this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm using proxyd as a generalize purpose consensus aware LB for nodes. In some configuration, checking for the
eth_syncingstate of the node is not ideal. For instance, for Orbit's nitro nodes, it is more important to have an active sequencer feed for the nodes than to check for the sync state between the node and the parent chain. For this use-case, I would like to configure proxyd to disable this check. Ideally I should add specific handling for nitro nodes, but that's probably outside the scope of proxyd.Tests
I ran proxyd without this config and confirmed syncing state is still checked. I ran proxyd with the config and confirmed syncing state is not checked.