Conversation
trianglesphere
force-pushed
the
jg/tx_forwarding_test
branch
from
3ea33a5 to
7d23149
Compare
This test verifies that tx forwarding properly sends the transaction to the sequencer. It still has some remaining oddities: - It could pass accidentally (not likely though) if no txpool gossip is not set - The transaction is received by the sequencer EE, but it is not accepted into the L2 chain.
trianglesphere
force-pushed
the
jg/tx_forwarding_test
branch
from
7d23149 to
c4b2f0d
Compare
I determined that the hive build step used GLIBC 2.32 but the previous machine executor used GLIBC 2.32. GLIBC is not backwards compatible like this.
mslipper
approved these changes
Oct 7, 2022
mslipper
left a comment
mslipper
left a comment
There was a problem hiding this comment.
Approving for now, but I think that not being mined issue is experienced in prod. I'll note that in the ticket I'm working on,
Author
Super interesting. Is this the thing that Ori posted about? This is then a pretty good test to ensure that we properly fix that issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a "tx forwarding" test to the
p2psim. It verifies that a transactionsent to a replica that has tx forwarding enabled shows up on the sequencer.
It still has some remaining oddities:
Metadata