Skip to content

Comments

Add simple ERC20 bindings#49

Merged
mslipper merged 1 commit intooptimismfrom
feat/erc20-bindings
Sep 29, 2022
Merged

Add simple ERC20 bindings#49
mslipper merged 1 commit intooptimismfrom
feat/erc20-bindings

Conversation

@mslipper
Copy link

This enables ERC20 deposit/withdrawal tests.

This enables ERC20 deposit/withdrawal tests.
Copy link

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maurelian
Copy link

maurelian commented Sep 29, 2022

I don't love having a ./contracts dir in the root. It's likely to misdirect/confuse visitors. If it is needed, could it be renamed or relocated?
LOL nvm, just realized I'm not in the monorepo.

@mslipper
Copy link
Author

The implementation in the monorepo does not contain any token-creation functionality, since it just exports the base OZ ERC20. This one mints tokens in the constructor, which makes testing easier since I can just send tokens from the deployer.

@mslipper
Copy link
Author

FYI @protolambda I'm going to merge this since I need a commit on Optimism to update dependencies. Let me know if you'd like me to revisit this solution, happy to do so on a separate PR.

@mslipper mslipper merged commit 8cbb5d7 into optimism Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants