Improve withdrawal reliability, parallelize tests#46
Merged
Conversation
mslipper
force-pushed
the
bugfix/wd-reliability
branch
from
b8b8561 to
b79cdee
Compare
The `--miner.gaslimit` flag was not being passed, which could lead to reorgs. I ran this 3 times locally, and all three executions passed.
mslipper
force-pushed
the
bugfix/wd-reliability
branch
from
184bf9e to
0a08693
Compare
mslipper
changed the title
protolambda
approved these changes
Sep 27, 2022
protolambda
left a comment
protolambda
left a comment
There was a problem hiding this comment.
I'm curious about the miner.gaslimit flag; how exactly does it cause reorgs? It should just repeat the gaslimit of the parent block.
LGTM otherwise
Author
|
I may be misunderstanding the usage of that flag, then - I was under the impression that if we didn't specify it, it'd cause a chain split that would eventually get picked up by the replicas. In any case, to match the env we're running in prod we'll need to specify it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--miner.gaslimitflag was not being passed, which could lead to reorgs. I also increased the max sequencer drift and sequencing window to match the devnet.Lastly, I parallelized the hive tests so that they finish more quickly and upload artifacts belonging to a single simulator. This makes debugging easier, and was necessary for me to figure out what was happening here.
Fixes ENG-2726