Conversation
a4c3248 to
5caf4af
Compare
mslipper
suggested changes
Apr 20, 2022
A new simulator for optimism devnet is added. It requires multiple optimism specific clients and their sequence is significant. So the only way to invoke the devnet simulator is to launch with the following clients: hive --sim optimism --client=ops-l1,ops-l2,ops-opnode,ops-l2os --docker.output The current test suite is adapter from ethereum/rpc and modified to suit the optimism devnet. Only a subset of the RPC tests are supported at the moment but more will be added later. Other test suites may extend the devnet in the future to extend test coverage.
8107c8d to
36b56ee
Compare
mslipper
approved these changes
Apr 28, 2022
|
This is amazing! Thanks for pushing this to completion while the team was offline with devconnect. In the future we may want to separate the container that pushes the contracts to L1 and the container that hosts the actual L1, since then we can test that e.g. all L1 clients (already in hive) work as RPC source. And similarly, once we get Erigon and/or other clients supported as L2 execution engine in Bedrock, we can test those by giving them the |
protolambda
pushed a commit
that referenced
this pull request
Jul 27, 2022
A new simulator for optimism devnet is added. It requires multiple optimism specific clients and their sequence is significant. So the only way to invoke the devnet simulator is to launch with the following clients: hive --sim optimism --client=ops-l1,ops-l2,ops-opnode,ops-l2os --docker.output The current test suite is adapter from ethereum/rpc and modified to suit the optimism devnet. Only a subset of the RPC tests are supported at the moment but more will be added later. Other test suites may extend the devnet in the future to extend test coverage.
mslipper
pushed a commit
that referenced
this pull request
Sep 8, 2022
A new simulator for optimism devnet is added. It requires multiple optimism specific clients and their sequence is significant. So the only way to invoke the devnet simulator is to launch with the following clients: hive --sim optimism --client=ops-l1,ops-l2,ops-opnode,ops-l2os --docker.output The current test suite is adapter from ethereum/rpc and modified to suit the optimism devnet. Only a subset of the RPC tests are supported at the moment but more will be added later. Other test suites may extend the devnet in the future to extend test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new simulator for optimism devnet:
The current simulator tests some basic RPC functions. More tests will be added next.