fix: latest value cleanups#248
Conversation
smartcontracts
left a comment
smartcontracts
left a comment
There was a problem hiding this comment.
Asked some clarifying questions.
| if err != nil { | ||
| log.Error("Cannot apply transaction", "msg", err) | ||
| } | ||
| s.SetLatestIndex(&i) |
There was a problem hiding this comment.
This can be removed because it now occurs within applyTransaction which would be called by maybeApplyTransaction. Is that correct?
| func (s *SyncService) applyTransaction(tx *types.Transaction) error { | ||
| meta := tx.GetMeta() | ||
| if tx.QueueOrigin().Uint64() == uint64(types.QueueOriginL1ToL2) { | ||
| s.SetLatestEnqueueIndex(meta.QueueIndex) |
There was a problem hiding this comment.
Is there ever a situation in which meta.QueueIndex could be greater than the previous enqueue index?
There was a problem hiding this comment.
Do you mean less than? It should not
See the note below the Types section here: https://github.com/ethereum-optimism/specs/blob/main/transaction-ingestor.md#types
| } | ||
| // Queue origin sequencer transactions should not have an index here | ||
| if meta.Index != nil { | ||
| s.SetLatestIndex(meta.Index) |
There was a problem hiding this comment.
Same question as above for this SetLatestIndex and the one below.
| if err != nil { | ||
| return fmt.Errorf("invalid transaction: %w", err) | ||
| } | ||
| tx.SetL1Timestamp(s.GetLatestL1Timestamp()) |
There was a problem hiding this comment.
Could this ever be a race condition?
|
Really what we want to do is implement the spec seen here: https://github.com/ethereum-optimism/specs/blob/main/transaction-ingestor.md |
|
Closing in favor of #271 |
2 participants
Description
Moves the timestamp logic into the same general area and also deduplicates the logic around setting the index/queue index
Metadata
Fixes
Contributing Agreement