This repository was archived by the owner on Apr 11, 2021. It is now read-only.
nitfixes: to get over the finish line#16
Merged
karlfloersch merged 6 commits intomasterfrom Aug 27, 2020
Merged
Conversation
karlfloersch
approved these changes
Aug 27, 2020
Contributor
karlfloersch
left a comment
karlfloersch
left a comment
There was a problem hiding this comment.
Time's up let's do this!
karlfloersch
added a commit
that referenced
this pull request
Nov 20, 2020
* Remove broken gas metering attempt * Add newline to fix lint * hardcode return value of eth_estimateGas to gas limit * evm: fix log message * state manager: safer calling * rpc: leave comment to help future debugging Co-authored-by: Karl Floersch <karl@karlfloersch.com> Co-authored-by: Kevin Ho <kevinjho1996@gmail.com>
karlfloersch
added a commit
that referenced
this pull request
Nov 20, 2020
* Remove broken gas metering attempt * Add newline to fix lint * hardcode return value of eth_estimateGas to gas limit * evm: fix log message * state manager: safer calling * rpc: leave comment to help future debugging Co-authored-by: Karl Floersch <karl@karlfloersch.com> Co-authored-by: Kevin Ho <kevinjho1996@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a fix and closes #12 and closes #13
Questions
Metadata
Fixes
Contributing Agreement