Add mainnet config for wstETH token#185
Merged
mslipper merged 3 commits intoethereum-optimism:masterfrom Sep 13, 2022
lidofinance:wsteth-mainnet
Merged
Add mainnet config for wstETH token#185mslipper merged 3 commits intoethereum-optimism:masterfrom lidofinance:wsteth-mainnet
mslipper merged 3 commits intoethereum-optimism:masterfrom
lidofinance:wsteth-mainnet
Conversation
roninjin10
reviewed
Sep 9, 2022
roninjin10
reviewed
Sep 9, 2022
roninjin10
suggested changes
Sep 9, 2022
Contributor
roninjin10
left a comment
roninjin10
left a comment
There was a problem hiding this comment.
Need to change the name of the overrides.bridge to overrides.optimismBridgeAddress
roninjin10
approved these changes
Sep 9, 2022
Contributor
|
@roninjin10 we changed the name of the override to |
This reverts commit 82a0d8a.
Contributor
Author
|
Should I revert the last commit? |
Contributor
|
Ooops! My bad Bogdan. Yea could you revert the latest commit please? |
Contributor
Author
|
Sure, changes were reverted |
Contributor
|
tyty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Ethereum/Optimism mainnet config for wstETH token.
Tests
According to the instruction, tests are not required.
Additional context
CrossChainMessengerclass from the @eth-optimism/sdk package, use theDAIBridgeAdapter.StandardBridgeAdapterwill throw the error: "token pair not supported by bridge" on thesupportsTokenPairmethod call (just like for the Kovan network).