Update standard-bridge-custom-token.mdx#766
Conversation
the constructor's bridge params should be L2StandardBridge.sol deployed address, not L2CrossDomainMessenger's address
WalkthroughThe primary change in this update is the modification of the Changes
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Additional context usedPath-based instructions (1)
Learnings (1)
LanguageTool
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (3)
pages/builders/app-developers/tutorials/standard-bridge-custom-token.mdx (3)
Line range hint
16-16: Grammar Improvement: Missing CommaConsider adding a comma after "ERC-20 tokens" for better readability.
- In this tutorial you'll learn how to bridge a custom ERC-20 token from Ethereum to an OP Stack chain using the Standard Bridge system. + In this tutorial, you'll learn how to bridge a custom ERC-20 token from Ethereum to an OP Stack chain using the Standard Bridge system.
Line range hint
31-31: Simplify LanguageThe phrase "in order to" could be simplified to "to" to make the sentences less wordy and more direct.
- Your L2 token contract must implement this interface in order to be bridged using the Standard Bridge system. + Your L2 token contract must implement this interface to be bridged using the Standard Bridge system. - You will need to add the OP Sepolia network to your wallet in order to follow this tutorial. + You will need to add the OP Sepolia network to your wallet to follow this tutorial.Also applies to: 52-52
Line range hint
122-122: Word Choice Improvement: Avoid Overused PhrasesThe word "exactly" could be replaced with a less frequently used alternative like "precisely" to enhance the tone of the documentation.
- This is exactly what this tutorial was meant to demonstrate. + This is precisely what this tutorial was meant to demonstrate.
2 participants
the constructor's bridge params should be L2StandardBridge.sol deployed address, not L2CrossDomainMessenger's address
Description
Change bridge address to L2StandardBridge address when custom L2 token deployed.
Tests
Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.
Additional context
Add any other context about the problem you're solving.
Metadata