Skip to content

Update schemas.mdx#727

Merged
cpengilly merged 1 commit intomainfrom
C-Emily-Furlong-patch-1
Jun 9, 2024
Merged

Update schemas.mdx#727
cpengilly merged 1 commit intomainfrom
C-Emily-Furlong-patch-1

Conversation

@C-Emily-Furlong
Copy link
Contributor

Description

Adding the new gov team multisig as an 'accepted' issuer for the RetroPGF badgeholders schema. We recently issued the round 4 badges from this multisig so it is important that developers know these are legit

Tests

none

Additional context

none

Metadata

  • Fixes #[Link to Issue]

Adding the new gov team multisig as an 'accepted' issuer for the RetroPGF badgeholders schema. We recently issued the round 4 badges from this multisig so it is important that developers know these are legit
@C-Emily-Furlong C-Emily-Furlong requested a review from a team as a code owner June 4, 2024 09:23
@C-Emily-Furlong C-Emily-Furlong requested a review from a team June 4, 2024 09:23
@netlify
Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit b33dff7
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/665edcfaeb020400080c3da8
😎 Deploy Preview https://deploy-preview-727--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 4, 2024

Walkthrough

The change involves updating the RetroPGF Badgeholders schema UID link in pages/chain/identity/schemas.mdx to include an additional attester address verification requirement. The new attester address 0xE4553b743E74dA3424Ac51f8C1E586fd43aE226F is added alongside the existing address 0x621477dBA416E12df7FF0d48E14c4D20DC85D7D9.

Changes

File Path Change Summary
pages/chain/identity/schemas.mdx Added an additional attester address verification requirement for the RetroPGF Badgeholders schema UID link.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant System

    User->>System: Request RetroPGF Badgeholders schema UID
    System-->>User: Provide schema UID
    User->>System: Verify attester address
    alt Verify with first address
        System-->>User: Address `0x621477dBA416E12df7FF0d48E14c4D20DC85D7D9` verified
    else Verify with second address
        System-->>User: Address `0xE4553b743E74dA3424Ac51f8C1E586fd43aE226F` verified
    end
Loading

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 39807a3 and b33dff7.

Files selected for processing (1)
  • pages/chain/identity/schemas.mdx (1 hunks)
Additional context used
Path-based instructions (1)
pages/chain/identity/schemas.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Use bold for prominence instead of all caps or italics.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for headers, buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
    "
Additional comments not posted (1)
pages/chain/identity/schemas.mdx (1)

29-29: The update to the RetroPGF Badgeholders schema UID is correctly implemented with the inclusion of the new attester address. This change ensures that developers recognize badges issued from the new multisig as legitimate.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
pages/chain/identity/schemas.mdx (1)

Line range hint 1-32: Please ensure the use of the Oxford comma in lists for consistency and clarity. Additionally, verify that all headers and proper nouns are using the correct title case as per the documentation guidelines.

@cpengilly cpengilly merged commit d59322d into main Jun 9, 2024
@cpengilly cpengilly deleted the C-Emily-Furlong-patch-1 branch June 9, 2024 20:46
@coderabbitai coderabbitai bot mentioned this pull request Oct 24, 2024
@coderabbitai coderabbitai bot mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants