Conversation
sigma
previously approved these changes
Mar 5, 2025
janjakubnanista
force-pushed
the
jan/erc20
branch
from
5e43dcb to
8323bcd
Compare
janjakubnanista
changed the title
janjakubnanista
force-pushed
the
jan/erc20
branch
2 times, most recently
from
b8a91f1 to
a253849
Compare
janjakubnanista
force-pushed
the
jan/erc20
branch
from
6a6aa9d to
86d356f
Compare
sigma
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Finishes a test that initiates withdrawals and checks whether the storage root has been updated. This addresses ethereum-optimism/op-reth#70 and should be migrated to run in that repo once the devnet-sdk is polished.
Outtakes
The test in question should only run if isthmus is enabled. A custom validator should be used, therefore, a custom validator should be easily written. I suggest we provide documentation, boilerplate and/or validator helpers to make this easierThe transactions require low-level interaction, especially gas estimates & limits. I suggest we provide helpers to make this part less of an eye sore